-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up miscellaneous code smells, eliminate most Guava use #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
December 27, 2023 21:29
15 tasks
ohltyler
reviewed
Dec 27, 2023
src/main/java/org/opensearch/flowframework/transport/ProvisionWorkflowTransportAction.java
Show resolved
Hide resolved
ohltyler
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice cleanup!
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-327-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89c03f9dd094f37575ad43ae8d57fc8b5982329c
# Push it to GitHub
git push --set-upstream origin backport/backport-327-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x Then, create a pull request where the |
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 28, 2023
…rch-project#327) Clean up misc. code smells, eliminate most Guava use Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
that referenced
this pull request
Dec 28, 2023
…va use (#327) (#332) Clean up miscellaneous code smells, eliminate most Guava use (#327) Clean up misc. code smells, eliminate most Guava use Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eliminated unnecessary throwing of
IOException
on workflow steps execution, left over from when we did more parsing in the steps.Used a linter based on SonarQube analysis and fixed up lots of little things.
() -> context.restore()
tocontext::restore
)Eliminated most use of Google Guava, which have been mostly useless since Java 9, specifically:
ImmutableList.of
replaced by Java'sList.of
orCollections.emptyList()
when emptyImmutableMap.of
replaced by Java'sMap.of
for 2 elements andMap.ofEntries
for more than one pair, orCollections.emptyMap()
if empty.Charset
replaced by Java'sStandardCharsets
Resource.toString()
yet as it's a bit more complex and should be handled in a separate PR. See issue [FEATURE] Eliminate all use of Google Guava #328By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.