Updated Workflow Interface #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 2 2
Lines 4 4
=====================================
Misses 4 4 |
dbwiddis
reviewed
Sep 12, 2023
There was a problem hiding this comment.
This part looks good.
Either need to have an internal object with an accessor for payload (data/fields/etc.) which doesn't seem to fit on an interface, or a different class to pass around the payload. See comments here
dbwiddis
reviewed
Sep 12, 2023
src/main/java/org/opensearch/flowframework/workflow/WorkflowStep.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
approved these changes
Sep 13, 2023
|
LGTM! Let's merge this and iterate as we figure out just exactly what data looks like! |
owaiskazi19
requested review from
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
ohltyler
approved these changes
Sep 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
* Updated Workflow Interface Signed-off-by: Owais Kazi <[email protected]> * Updated method definition to handle input/output Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit 0f0b65d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Sep 13, 2023
Updated Workflow Interface (#30) * Updated Workflow Interface * Updated method definition to handle input/output --------- (cherry picked from commit 0f0b65d) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Owais Kazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated Workflow Interface:
WorkflowStep.Issues Resolved
Part of #29
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.