[Feature/agent_framework] Registers root agent with an agentId in ToolSteps #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
changed the title
dbwiddis
approved these changes
Dec 3, 2023
| @@ -240,7 +231,7 @@ private String getLlmModelId(Map<String, String> previousNodeInputs, Map<String, | |||
|
|
|||
| private LLMSpec getLLMSpec(String llmModelId, Map<String, String> llmParameters) { | |||
| if (llmModelId == null) { | |||
| throw new IllegalArgumentException("model id for llm is null"); | |||
| throw new FlowFrameworkException("model id for llm is null", RestStatus.BAD_REQUEST); | |||
There was a problem hiding this comment.
Can we pass workflow ID and step ID to this method to include in the exception? (Can handle in a future PR)
There was a problem hiding this comment.
We need to do this for all the exception message for the workflow steps. I can raise a follow up PR for all of them.
| // Case when modelId is not present at all | ||
| if (llmModelId == null) { | ||
| registerAgentModelFuture.completeExceptionally( | ||
| new FlowFrameworkException("llm model id is not provided", RestStatus.BAD_REQUEST) |
There was a problem hiding this comment.
Please add workflowID and step (node) ID to this error message. (Can handle in a future PR)
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
register-root
branch
from
cbc3661
to
9fd114a
Compare
Signed-off-by: Owais Kazi <[email protected]>
joshpalis
approved these changes
Dec 4, 2023
dbwiddis
merged commit 53daf61
into
opensearch-project:feature/agent_framework
10 checks passed
28 tasks
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…lSteps (opensearch-project#242) * Add agentId to parameters map for root agent Signed-off-by: Owais Kazi <[email protected]> * Modified ToolStep with new Util method Signed-off-by: Owais Kazi <[email protected]> * Integrated RegisterAgentStep with new Util method Signed-off-by: Owais Kazi <[email protected]> * Spotless fixes Signed-off-by: Owais Kazi <[email protected]> * Removed TODO Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…lSteps (opensearch-project#242) * Add agentId to parameters map for root agent Signed-off-by: Owais Kazi <[email protected]> * Modified ToolStep with new Util method Signed-off-by: Owais Kazi <[email protected]> * Integrated RegisterAgentStep with new Util method Signed-off-by: Owais Kazi <[email protected]> * Spotless fixes Signed-off-by: Owais Kazi <[email protected]> * Removed TODO Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
…lSteps (#242) * Add agentId to parameters map for root agent Signed-off-by: Owais Kazi <[email protected]> * Modified ToolStep with new Util method Signed-off-by: Owais Kazi <[email protected]> * Integrated RegisterAgentStep with new Util method Signed-off-by: Owais Kazi <[email protected]> * Spotless fixes Signed-off-by: Owais Kazi <[email protected]> * Removed TODO Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
…lSteps (opensearch-project#242) * Add agentId to parameters map for root agent Signed-off-by: Owais Kazi <[email protected]> * Modified ToolStep with new Util method Signed-off-by: Owais Kazi <[email protected]> * Integrated RegisterAgentStep with new Util method Signed-off-by: Owais Kazi <[email protected]> * Spotless fixes Signed-off-by: Owais Kazi <[email protected]> * Removed TODO Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
…lSteps (#242) * Add agentId to parameters map for root agent Signed-off-by: Owais Kazi <[email protected]> * Modified ToolStep with new Util method Signed-off-by: Owais Kazi <[email protected]> * Integrated RegisterAgentStep with new Util method Signed-off-by: Owais Kazi <[email protected]> * Spotless fixes Signed-off-by: Owais Kazi <[email protected]> * Removed TODO Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
agent_id. Ref: [FEATURE] Register Agent Workflow Step #194 (comment)TODO:#241Issues Resolved
Closes #194
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.