[Backport 2.x] Encrypt/Decrypt template credentials #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* added RegisterRemoteModelStep and tests Signed-off-by: Joshua Palis <[email protected]> * Adding RegisterLocalModelStep, fixing tests, adding input/ouput definitions to workflow step json Signed-off-by: Joshua Palis <[email protected]> * Fixing javadoc warnings, fixing log message Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments,making description field optional for RegisterRemoteModelStep and RegisterLocalModelStep Signed-off-by: Joshua Palis <[email protected]> * moving modelConfig builder before adding allConfig Signed-off-by: Joshua Palis <[email protected]> * initial implementation Signed-off-by: Joshua Palis <[email protected]> * Fixing create workflow transport action Signed-off-by: Joshua Palis <[email protected]> * Removing duplicate register_remote_model validator Signed-off-by: Joshua Palis <[email protected]> * Adding bouncy castle dependency to resolve encryption issue Signed-off-by: Joshua Palis <[email protected]> * Fixing CreateWorkflowTransportActionTests Signed-off-by: Joshua Palis <[email protected]> * Adding initial unit tests for encryptor utils Signed-off-by: Joshua Palis <[email protected]> * Implemented encryption/decryption for workflow node user inputs with credential Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments Signed-off-by: Joshua Palis <[email protected]> * Suppressing unchecked warning, making credential strings constants Signed-off-by: Joshua Palis <[email protected]> * Removing setMasterKey from initializeMasterKey method Signed-off-by: Joshua Palis <[email protected]> * Adding final template encryption decryption test Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments, changing master key index name to config, fixes error messages as well. Added create time field to config index, ensured that updates are also encrypted Signed-off-by: Joshua Palis <[email protected]> * Added TODO Signed-off-by: Joshua Palis <[email protected]> * changing getMasterKeyIndexMapping method name Signed-off-by: Joshua Palis <[email protected]> * Removing unnecessary aws sdk dependency Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 772fbbd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
joshpalis
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 772fbbd from #197.