Improve workflow step execute API #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Daniel Widdis <[email protected]>
This was referenced Nov 29, 2023
joshpalis
approved these changes
Nov 29, 2023
owaiskazi19
approved these changes
Nov 30, 2023
dbwiddis
merged commit cac2e0b
into
opensearch-project:feature/agent_framework
10 checks passed
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Nov 30, 2023
* Improve workflow step execute API Signed-off-by: Daniel Widdis <[email protected]> * Fix typo Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added a commit
that referenced
this pull request
Nov 30, 2023
Improve workflow step execute API (#215) * Improve workflow step execute API * Fix typo --------- Signed-off-by: Daniel Widdis <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
Improve workflow step execute API (#215) * Improve workflow step execute API * Fix typo --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 7c06865) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Nov 30, 2023
… (#222) [Backport-main] Improve workflow step execute API (#215) (#221) Improve workflow step execute API (#215) * Improve workflow step execute API * Fix typo --------- (cherry picked from commit 7c06865) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the workflow step
execute()API to:nodeIdto identify the step uniquelyIssues Resolved
Part of #210
Submitting with the API change first in order to get compiling classes with the new API, to enable in-progress work to update the API and work in parallel.
Left a TODO to improve the parsing for collecting previous data from the list; for now, recreating the workflow data list to preserve the previous behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.