Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Put plugin API behind a feature flag #145

Merged
merged 1 commit into from
Nov 3, 2023
Merged

[Backport 2.x] Put plugin API behind a feature flag #145

merged 1 commit into from
Nov 3, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport aad17d0 from #142.

@github-actions
Put plugin API behind a feature flag (#142)
32f778f 
* Put plugin API behind a feature flag

Signed-off-by: Daniel Widdis <[email protected]>

* Add test for feature flag disabled

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit aad17d0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #145 (32f778f) into 2.x (80efe24) will increase coverage by 0.48%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x     #145      +/-   ##
============================================
+ Coverage     67.09%   67.58%   +0.48%     
- Complexity      311      318       +7     
============================================
  Files            37       38       +1     
  Lines          1468     1490      +22     
  Branches        139      140       +1     
============================================
+ Hits            985     1007      +22     
  Misses          434      434              
  Partials         49       49
Files Coverage Δ
.../opensearch/flowframework/FlowFrameworkPlugin.java 100.00% <100.00%> (ø)
...ork/common/FlowFrameworkFeatureEnabledSetting.java 100.00% <100.00%> (ø)
...h/flowframework/rest/RestCreateWorkflowAction.java 56.25% <100.00%> (+12.25%) ⬆️
...lowframework/rest/RestProvisionWorkflowAction.java 56.66% <100.00%> (+8.66%) ⬆️

@joshpalis joshpalis merged commit 074b668 into 2.x Nov 3, 2023
15 checks passed
@github-actions github-actions bot deleted the backport/backport-142-to-2.x branch November 3, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpalis joshpalis joshpalis approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joshpalis