Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop duplicate GitHub Action runs on backport branches #128

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Stop duplicate GitHub Action runs on backport branches #128

merged 2 commits into from
Oct 31, 2023

Conversation

dbwiddis
Copy link
Member

Description

Prevents GitHub Actions from PRs generated on repository branches from duplicating workflows

Issues Resolved

Fixes #101

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #128 (144652d) into main (9dffc0a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #128   +/-   ##
=========================================
  Coverage     67.09%   67.09%           
  Complexity      276      276           
=========================================
  Files            35       35           
  Lines          1319     1319           
  Branches        125      125           
=========================================
  Hits            885      885           
  Misses          390      390           
  Partials         44       44           

@amitgalitz
Copy link
Member

Will this stop all workflows on 2.x backport for example? Could there be cases when we want that to catch times when changes we made in main are not compatible with 2.x? Happened on AD in few cases

@dbwiddis
Copy link
Member Author

Will this stop all workflows on 2.x backport for example?

It will not stop PR workflows against any branch other than the ones created with the backport/ prefix, which are created by the "Backport" GitHub action. This is no different than "not running GHA on someone else's repository".

@joshpalis joshpalis merged commit 7d9cd84 into opensearch-project:main Oct 31, 2023
21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 31, 2023
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Co-authored-by: Joshua Palis <[email protected]>
(cherry picked from commit 7d9cd84)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis added a commit that referenced this pull request Oct 31, 2023
…#133)

Stop duplicate GitHub Action runs on backport branches (#128)




(cherry picked from commit 7d9cd84)

Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Palis <[email protected]>
@dbwiddis dbwiddis deleted the dupe-ci branch November 11, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Backport CI is duplicating workflow runs
4 participants