Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Create Integration Test framework #73

Closed
2 tasks done
owaiskazi19 opened this issue Oct 5, 2023 · 3 comments · Fixed by #251
Closed
2 tasks done

[FEATURE] Create Integration Test framework #73

owaiskazi19 opened this issue Oct 5, 2023 · 3 comments · Fixed by #251
Assignees
Labels
enhancement New feature or request v2.12.0

Comments

@owaiskazi19
Copy link
Member

owaiskazi19 commented Oct 5, 2023

Is your feature request related to a problem?

Currently, the project just has unit tests for the features built until now.

What solution would you like?

Taking an example from ml-commons. Integtest task in build.gradle like

What alternatives have you considered?

A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@dbwiddis
Copy link
Member

dbwiddis commented Oct 5, 2023

We currently have an IT framework as part of the template.

This test validates that the plugin was installed.
https://github.com/opensearch-project/opensearch-ai-flow-framework/blob/main/src/test/java/org/opensearch/flowframework/FlowFrameworkPluginIT.java

That test runs with every CI.

What is currently missing?

@owaiskazi19
Copy link
Member Author

Ah! I missed the framework completely @dbwiddis. Thanks for the pointer.
Also, IMO we should have a GHA to run integ test separately than our usual build CI.

@dbwiddis
Copy link
Member

Sure, we should run them separately.

Also, the IT tests is flaky. It often fails with a 404 error, but works on retry.
Any idea how to fix it?

org.opensearch.client.ResponseException: method [GET], host [http://0.0.0.0:0/], URI [/_cat/plugins], status line [HTTP/1.1 404 Not Found]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants