Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Complete Register Local Model Implementation #345

Closed
3 tasks done
dbwiddis opened this issue Jan 2, 2024 · 0 comments · Fixed by #350
Closed
3 tasks done

[FEATURE] Complete Register Local Model Implementation #345

dbwiddis opened this issue Jan 2, 2024 · 0 comments · Fixed by #350
Assignees
Labels
enhancement New feature or request v2.12.0

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Jan 2, 2024

Is your feature request related to a problem?

The sparse model tool requires the Register Local Model step to be completed. It is currently missing some changes made only to the Register Remote Model step such as updating state index, and handling deploy=true. Its integration tests are currently disabled due to these shortcomings.

What solution would you like?

  • Update the step to record its registered model in the state index
  • Update the step to handle the boolean deploy = true parameter (see Support deploy=true on RegisterRemoteModelStep #340 for necessary steps)
  • Enable its integration test and add a new one for the deploy=true variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.12.0
Projects
None yet
2 participants