[BUG] Status changed to PROVISIONING when failed

[owaiskazi19]

What is the bug?

[2023-11-24T03:01:22,448][ERROR][o.o.f.t.ProvisionWorkflowTransportAction] [ip-172-31-56-214] Provisioning failed for workflow IKRG_4sB9nj1vxRLOlJI : org.opensearch.flowframework.exception.FlowFrameworkException: java.lang.ClassCastException: class java.util.HashMap cannot be cast to class org.opensearch.ml.common.agent.LLMSpec (java.util.HashMap is in module java.base of loader 'bootstrap'; org.opensearch.ml.common.agent.LLMSpec is in unnamed module of loader java.net.FactoryURLClassLoader @2ba5aa7a)
[2023-11-24T03:01:22,470][INFO ][o.o.f.t.ProvisionWorkflowTransportAction] [ip-172-31-56-214] updated workflow IKRG_4sB9nj1vxRLOlJI state to PROVISIONING

How can one reproduce the bug?

1. Try to create a case where the provisioning fails
2. Status changes to PROVISIONING

What is the expected behavior?

Status should be changed to FAILED.

What is your host/environment?

Ubuntu

Do you have any screenshots?

If applicable, add screenshots to help explain your problem.

Do you have any additional context?

Add any other context about the problem.

[amitgalitz]

Which branch was this on, I have previously tested that we wrote status as FAILED when provisioning failed. Might have gone wrong in some PR since

[owaiskazi19]

Which branch was this on, I have previously tested that we wrote status as FAILED when provisioning failed. Might have gone wrong in some PR since

feature/agent_framework, not sure about main

[amitgalitz]

Fixed by both moving update of state index to happen after the step and also changing the logs statement. #253