Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement Throttling for Max Workflows to be created #150

Closed
owaiskazi19 opened this issue Nov 7, 2023 · 0 comments · Fixed by #151
Closed

[FEATURE] Implement Throttling for Max Workflows to be created #150

owaiskazi19 opened this issue Nov 7, 2023 · 0 comments · Fixed by #151
Assignees
Labels
enhancement New feature or request untriaged

Comments

@owaiskazi19
Copy link
Member

Is your feature request related to a problem?

Currently, we don't have a provision to limit the number of workflows(documents) to be saved in Global Context index. The size of the index can be large and thus can impact the memory of the cluster. To avoid this a limit should be added which would let the user know the maximum limit to create the workflows has been reached. A setting should handle the maximum limit, which can be dynamic and can be increased if requested.

What solution would you like?

Before saving the workflows using the Create API, throttle the request and return an error message to the user.

Do you have any additional context?

Dynamic Setting would look like the below

 Setting.intSetting(
        "plugins.flow_framework.max_workflows",
        100,
        0,
        1000,
        Setting.Property.NodeScope,
        Setting.Property.Dynamic
    );

Where 100 is the default value, 0 is the min value and 1000 is the max limit. Need input on what will be the best values for all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant