Addressing PR comments,making description field optional for Register…

…RemoteModelStep and RegisterLocalModelStep Signed-off-by: Joshua Palis <[email protected]>
opensearch-project · Nov 8, 2023 · 5f0a357 · 5f0a357
1 parent 366f05e
commit 5f0a357
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 14 deletions.
diff --git a/src/main/java/org/opensearch/flowframework/workflow/RegisterLocalModelStep.java b/src/main/java/org/opensearch/flowframework/workflow/RegisterLocalModelStep.java
@@ -145,17 +145,8 @@ public void onFailure(Exception e) {
             }
         }
 
-        if (Stream.of(
-            modelName,
-            modelVersion,
-            description,
-            modelFormat,
-            modelGroupId,
-            embeddingDimension,
-            frameworkType,
-            modelContentHashValue,
-            url
-        ).allMatch(x -> x != null)) {
+        if (Stream.of(modelName, modelVersion, modelFormat, modelGroupId, embeddingDimension, frameworkType, modelContentHashValue, url)
+            .allMatch(x -> x != null)) {
 
             // Create model configuration, assuming null pooling mode, null model max length, normalize results set to false
             TextEmbeddingModelConfigBuilder builder = TextEmbeddingModelConfig.builder();

diff --git a/src/main/java/org/opensearch/flowframework/workflow/RegisterRemoteModelStep.java b/src/main/java/org/opensearch/flowframework/workflow/RegisterRemoteModelStep.java
@@ -115,7 +115,7 @@ public void onFailure(Exception e) {
             }
         }
 
-        if (Stream.of(modelName, functionName, description, connectorId).allMatch(x -> x != null)) {
+        if (Stream.of(modelName, functionName, connectorId).allMatch(x -> x != null)) {
 
             MLRegisterModelInputBuilder builder = MLRegisterModelInput.builder();
 

diff --git a/src/main/resources/mappings/workflow-steps.json b/src/main/resources/mappings/workflow-steps.json
@@ -43,7 +43,6 @@
         "inputs":[
             "name",
             "version",
-            "description",
             "model_format",
             "model_group_id",
             "model_content_hash_value",
@@ -61,7 +60,6 @@
         "inputs": [
             "name",
             "function_name",
-            "description",
             "connector_id"
         ],
         "outputs": [