Add has parent query #8365
Add has parent query #8365
Conversation
Signed-off-by: Fanit Kolchina <[email protected]>
kolchfa-aws
requested review from
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
There was a problem hiding this comment.
@kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!
| @@ -188,6 +322,7 @@ The following table lists all top-level parameters supported by `has_child` quer | |||
| | `max_children` | Optional | The maximum number of matching child documents for a parent document. If exceeded, the parent document is excluded from the search results. | | |||
| | `min_children` | Optional | The minimum number of matching child documents required for a parent document to be included in the results. If not met, the parent is excluded. Default is `1`.| | |||
| | `score_mode` | Optional | Defines how scores of matching child documents influence the parent document's score. Valid values are: <br> - `none`: Ignores the relevance scores of child documents and assigns a score of `0` to the parent document. <br> - `avg`: Uses the average relevance score of all matching child documents. <br> - `max`: Assigns the highest relevance score from the matching child documents to the parent. <br> - `min`: Assigns the lowest relevance score from the matching child documents to the parent. <br> - `sum`: Sums the relevance scores of all matching child documents. <br> Default is `none`. | | |||
| | `inner_hits` | Optional | If provided, returns the underlying hits (child documents) that matched the query. | | |||
There was a problem hiding this comment.
Is "underlying" necessary here? "matched" => "match"?
There was a problem hiding this comment.
Yes (see above)
_query-dsl/joining/has-parent.md
Outdated
| ``` | ||
| {% include copy-curl.html %} | ||
|
|
||
| The response contains the products sorted by the highest parent `customer_satisfaction`: |
There was a problem hiding this comment.
Either a comma should follow "products", or "the" should be omitted before "products".
| @@ -176,6 +176,140 @@ The response returns both brands: | |||
| } | |||
| ``` | |||
|
|
|||
| ## Retrieving inner hits | |||
|
|
|||
| To return child documents that matched the query, provide the `inner_hits` parameter: | |||
There was a problem hiding this comment.
I think it's better to leave as "matched" because the parent documents are returned as a consequence of the child documents matching the query.
|
|
||
| ## Retrieving inner hits | ||
|
|
||
| To return parent documents that matched the query, provide the `inner_hits` parameter: |
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
* Add has parent query Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit c0127fb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Add has parent query
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.