Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial comments on #8339 #8340

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Editorial comments on #8339 #8340

merged 1 commit into from
Sep 19, 2024

Conversation

Naarcha-AWS
Copy link
Collaborator

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naarcha-AWS <[email protected]>
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@Naarcha-AWS Naarcha-AWS added the backport 2.17 Backport for version 2.17 label Sep 19, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 5 - Editorial review PR: Editorial review in progress labels Sep 19, 2024
@Naarcha-AWS Naarcha-AWS merged commit 81a1355 into main Sep 19, 2024
10 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-8340-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 81a1355db417004766f4f395a3123257b40d0bdc
# Push it to GitHub
git push --set-upstream origin backport/backport-8340-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-8340-to-2.17.

Naarcha-AWS added a commit that referenced this pull request Sep 19, 2024
Signed-off-by: Naarcha-AWS <[email protected]>
(cherry picked from commit 81a1355)
Naarcha-AWS added a commit that referenced this pull request Sep 19, 2024
Signed-off-by: Naarcha-AWS <[email protected]>
(cherry picked from commit 81a1355)
noahstaveley pushed a commit to noahstaveley/documentation-website that referenced this pull request Sep 23, 2024
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Noah Staveley <[email protected]>
noahstaveley pushed a commit to noahstaveley/documentation-website that referenced this pull request Sep 23, 2024
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Noah Staveley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.17 Backport for version 2.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants