Add Sycamore page #8234
Merged
Add Sycamore page #8234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create Sycamore page Signed-off-by: jonfritz <[email protected]>
Add to docs Signed-off-by: jonfritz <[email protected]>
Add info to docs page Signed-off-by: jonfritz <[email protected]>
jonfritz
requested review from
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@kolchfa-aws thanks for helping! Please let me know if I need to assign anyone else. |
|
Thanks, @jonfritz! Could you also add Sycamore to the index page of the Tools section? https://opensearch.org/docs/latest/tools/ |
kolchfa-aws
reviewed
Sep 12, 2024
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Correct typo Signed-off-by: jonfritz <[email protected]>
|
Updated and took the changes. Thanks for the review! |
kolchfa-aws
reviewed
Sep 12, 2024
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]>
Updates from suggestions Signed-off-by: jonfritz <[email protected]>
Updating index with Sycamore Signed-off-by: jonfritz <[email protected]>
|
Sorry! Missed those suggestions, and now approved them. Also, added a note on index.md in the same pattern as the others. Thanks again! |
kolchfa-aws
reviewed
Sep 12, 2024
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
natebower
reviewed
Sep 16, 2024
There was a problem hiding this comment.
@jonfritz @kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!
_tools/sycamore.md
Outdated
|
|
||
| * Read documents into a [DocSet](https://sycamore.readthedocs.io/en/stable/sycamore/get_started/concepts.html#docsets) | ||
| * [Partition documents](https://sycamore.readthedocs.io/en/stable/sycamore/transforms/partition.html) into structured JSON elements | ||
| * Extract metadata, filter and clean data using [transforms](https://sycamore.readthedocs.io/en/stable/sycamore/APIs/docset.html) |
There was a problem hiding this comment.
Do we mean "Extract, filter, and clean metadata using transforms."? (add period)
kolchfa-aws
reviewed
Sep 16, 2024
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
kolchfa-aws
approved these changes
Sep 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
* Create sycamore.md Create Sycamore page Signed-off-by: jonfritz <[email protected]> * Update sycamore.md Add to docs Signed-off-by: jonfritz <[email protected]> * Update sycamore.md Add info to docs page Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update sycamore.md Correct typo Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update sycamore.md Updates from suggestions Signed-off-by: jonfritz <[email protected]> * Update index.md Updating index with Sycamore Signed-off-by: jonfritz <[email protected]> * Update _tools/index.md Signed-off-by: kolchfa-aws <[email protected]> * Add front matter Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: jonfritz <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit e0045f9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noahstaveley
pushed a commit
to noahstaveley/documentation-website
that referenced
this pull request
Sep 23, 2024
* Create sycamore.md Create Sycamore page Signed-off-by: jonfritz <[email protected]> * Update sycamore.md Add to docs Signed-off-by: jonfritz <[email protected]> * Update sycamore.md Add info to docs page Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update sycamore.md Correct typo Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update _tools/sycamore.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: jonfritz <[email protected]> * Update sycamore.md Updates from suggestions Signed-off-by: jonfritz <[email protected]> * Update index.md Updating index with Sycamore Signed-off-by: jonfritz <[email protected]> * Update _tools/index.md Signed-off-by: kolchfa-aws <[email protected]> * Add front matter Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: jonfritz <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Noah Staveley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a page about using the open source Sycamore library for ETL into OpenSearch.
Issues Resolved
N/A
Version
2.9--2.16
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.