Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating data sources docs # 7680 #7800
Updating data sources docs # 7680 #7800
Changes from 2 commits
9a13153
ceeb9f0
50969ec
e58b02f
a3b484a
988a2a3
3f85568
a5fa35f
0501b54
2b43758
991ff62
6aa614b
7aae9dd
ceb45ba
847be09
a0c5520
ae8fa8e
aec8bc3
51c3a42
532213b
1d03bec
49e5384
3daccbf
5c9f050
f45bf68
a09f26d
ff765b7
6824b77
3e8ee23
ae1e46c
e8ed29c
17e0e47
487aea0
e1a8fda
48db453
2cd1ec4
ec765b0
19aba84
786634d
52ee85d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 8 in _dashboards/management/connect-prometheus.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This page shows you how to use the..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there may be boilerplate for this elsewhere that we should be consistent with. It should read something like "Make sure that you have configured all necessary prerequisites and permissions for/in order to..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revised sentence to eliminate wordiness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revised sentence to eliminate wordiness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revised sentence to eliminate wordiness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revised sentence to eliminate wordiness
Check warning on line 45 in _dashboards/management/connect-prometheus.md
GitHub Actions / style-job
Check failure on line 26 in _dashboards/management/data-sources.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data source "permissions" (plural)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is accurate anymore, since I think these two pages merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derek-ho As far as I'm aware the pages are due to be merged in future versions, possibly 2.17, the current state (from 2.11 to current) is still via two separate pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have merged the experience in 2.16. So this is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion, @AntonEliatra! They DID make changes in 2.16 to the UI. Since the release is today (8/7), you should be able to see the updates tomorrow in the playground for testing purposes. In addition, @RyanL1997 is going to capture a video of the new flow and add it to a doc issue.
We'll have to update the rest of documentation for the new changes post-2.16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RyanL1997 I don't see the option Management > Data sources in my local environment running 2.16. I only have the option to go through Dashboards Management. Please let me know if Management > Data sources is available in 2.16. Please review lines 39--41 and make any necessary changes for technical accuracy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this one we may need to change the picture. Since the old datasource in observability has been unregistered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User can use the create button and navi to the card view for selection:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RyanL1997 Which version of OS are you using? With 2.15 I'm not able to see the view that you pasted above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntonEliatra: The screenshots are from 2.16. We should be releasing in the next couple of days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Naarcha-AWS Should I change the version in the PR details to 2.15, as this will still be relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion, @AntonEliatra! They DID make changes in 2.16 to the UI. Since the release is today (8/7), you should be able to see the updates tomorrow in the playground for testing purposes. In addition, @RyanL1997 is going to capture a video of the new flow and add it to a doc issue.
We'll have to update the rest of documentation for the new changes post-2.16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi folks, thanks for the fast follow up and here is the issue I created with some details of flow diffs: #7948, feel free to drop some comments/thoughts if you have some questions. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on updating the documentation based on the above. I think some effort is needed in explaining the difference between Zero-ETL and Managed Data Streams (MDS) before jumping into "How-to", as this can be a point of confusion for many users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RyanL1997 are you able to confirm when does the user need to configure :
plugins.query.datasources.encryption.masterkey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntonEliatra @RyanL1997 Suggested text: When the multiple data sources feature is disabled (
data_source.enabled: false
), you can only see and work with local, unmanaged data sources on your cluster, and cannot work with or manage multiple data sources.