Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding retrieve specific fields docs #7664

Conversation

AntonEliatra
Copy link
Contributor

Description

Adding documentation for Retrieval of specific fields

Issues Resolved

Part of #4785

Version

all

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…onEliatra/documentation-website into adding-retrieve-specific-fields-docs
@hdhalter
Copy link
Contributor

@rishabhmaurya , can you please do a tech review? Thank you.

Copy link
Contributor

@rishabhmaurya rishabhmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonEliatra looks technically correct, couple of minor comment. Thank you for contributing and covering all possible cases.

_search-plugins/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/retrieve-specific-fields.md Outdated Show resolved Hide resolved
@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Jul 18, 2024
@Naarcha-AWS Naarcha-AWS added the search-and-query Issue: Issues related to search and query features label Aug 7, 2024
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AntonEliatra! Please see my comments and let me know if you have any questions.

_search-plugins/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/retrieve-specific-fields.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Aug 15, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonEliatra @kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!

_search-plugins/searching-data/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/searching-data/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/searching-data/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/searching-data/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/searching-data/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/searching-data/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/searching-data/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/searching-data/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/searching-data/retrieve-specific-fields.md Outdated Show resolved Hide resolved
_search-plugins/searching-data/retrieve-specific-fields.md Outdated Show resolved Hide resolved
@kolchfa-aws
Copy link
Collaborator

@AntonEliatra Could you also add this and the search shard routing to the table in the index page for searching data? https://opensearch.org/docs/latest/search-plugins/searching-data/index/

AntonEliatra and others added 2 commits August 19, 2024 17:43
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Anton Rubin <[email protected]>
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AntonEliatra!

@kolchfa-aws kolchfa-aws merged commit 18acb50 into opensearch-project:main Aug 19, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 19, 2024
* Adding retrieve specific fields documentation #7507

Signed-off-by: AntonEliatra <[email protected]>

* Adding retrieve specific fields documentation #7507

Signed-off-by: AntonEliatra <[email protected]>

* Update retrieve-specific-fields.md

Signed-off-by: AntonEliatra <[email protected]>

* updating retrieve specific field typos

Signed-off-by: AntonEliatra <[email protected]>

* updating retrieve specific field typos

Signed-off-by: AntonEliatra <[email protected]>

* adding details per comments

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* updating as per review comments

Signed-off-by: Anton Rubin <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* updating as per PR comments

Signed-off-by: Anton Rubin <[email protected]>

---------

Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Anton Rubin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 18acb50)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 19, 2024
* Adding retrieve specific fields documentation #7507

Signed-off-by: AntonEliatra <[email protected]>

* Adding retrieve specific fields documentation #7507

Signed-off-by: AntonEliatra <[email protected]>

* Update retrieve-specific-fields.md

Signed-off-by: AntonEliatra <[email protected]>

* updating retrieve specific field typos

Signed-off-by: AntonEliatra <[email protected]>

* updating retrieve specific field typos

Signed-off-by: AntonEliatra <[email protected]>

* adding details per comments

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* updating as per review comments

Signed-off-by: Anton Rubin <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* updating as per PR comments

Signed-off-by: Anton Rubin <[email protected]>

---------

Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Anton Rubin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 18acb50)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@AntonEliatra AntonEliatra deleted the adding-retrieve-specific-fields-docs branch August 20, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Editorial review PR: Editorial review in progress backport 2.16 search-and-query Issue: Issues related to search and query features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants