Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental feature labels and flags for OS Assistant #6745

Merged
merged 6 commits into from
Mar 28, 2024

Conversation

kolchfa-aws
Copy link
Collaborator

Closes #6713

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kolchfa-aws kolchfa-aws self-assigned this Mar 20, 2024
@hdhalter hdhalter added release-notes PR: Include this PR in the automated release notes v2.13.0 labels Mar 20, 2024
@kolchfa-aws
Copy link
Collaborator Author

@ylwu-amzn Could you please review this PR?

@hdhalter hdhalter added the 4 - Doc review PR: Doc review in progress label Mar 26, 2024
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 44 to 46
```yaml
observability.query_assist.ppl_agent_name: "PPL agent"
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is no longer valid.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Comment on lines 42 to 45
By default, **Query Assistant** is enabled in OpenSearch Dashboards. To configure Query Assistant, locate your copy of the `opensearch_dashboards.yml` file and set the following option:

```
observability.query_assist.enabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep this removed part and say if they want to disable it, they can set this setting to false.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a sentence about that on line 50.

Signed-off-by: Fanit Kolchina <[email protected]>
@kolchfa-aws kolchfa-aws merged commit 4c507b5 into main Mar 28, 2024
4 checks passed
@kolchfa-aws kolchfa-aws deleted the assistant-ga branch March 29, 2024 16:20
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 4 - Doc review PR: Doc review in progress labels Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] OpenSearch Assistant going GA
3 participants