Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding explanation for editing permissions 20230825 #6606
Adding explanation for editing permissions 20230825 #6606
Changes from 13 commits
b574c9e
3f32e80
289943a
7195c42
a918857
5c88efa
b05db06
97ba3c9
e839012
9dde189
7a29048
2864a8d
7bfc487
0340211
a33218b
09a6e06
c4cca6b
c4f265e
cb681ae
af79721
24afe20
415786f
6afb195
06065f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are users looking for as they review the Index permissions section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inside the 'index permissions' area/heading, is the DSL multiline text box, so it was just a step to get to the DSL area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not following this bulleted list. It appears to contain content duplicated from above, and the structure doesn't work in terms of introducing the query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can likely just remove this bulleted list.
Check failure on line 17 in _security/access-control/users-roles.md
GitHub Actions / style-job
Check warning on line 25 in _security/access-control/users-roles.md
GitHub Actions / style-job
Check failure on line 27 in _security/access-control/users-roles.md
GitHub Actions / style-job
Check failure on line 92 in _security/access-control/users-roles.md
GitHub Actions / style-job
Check warning on line 98 in _security/access-control/users-roles.md
GitHub Actions / style-job