Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Default Model Id for Neural Sparse Search Query clause #6652

Closed
1 of 4 tasks
zhichao-aws opened this issue Mar 12, 2024 · 5 comments · Fixed by #6725
Closed
1 of 4 tasks

[DOC] Default Model Id for Neural Sparse Search Query clause #6652

zhichao-aws opened this issue Mar 12, 2024 · 5 comments · Fixed by #6725
Assignees
Labels
3 - Done Issue is done/complete v2.13.0

Comments

@zhichao-aws
Copy link
Member

zhichao-aws commented Mar 12, 2024

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.

In 2.11 release, we introduce neural_query_enricher to support default model id in neural search (ref). In 2.13 release, we enhance the neural_query_enricher to enable it to support neural sparse query, too. (PR link). The API invokation works same as the neural query.

Now we want to change existing documentation to inform users about this feature. We can modify the description of neural_query_enricher in search-processors.md and neural-query-enricher.md to add neural sparse search. We can also add a section "## Setting a default model on an index or field" in neural-sparse-search.md like the doc for semantic search (ref).

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
related issues&PR:
#5060
opensearch-project/neural-search#614
#5121

@hdhalter
Copy link
Contributor

Thanks, @zhichao-aws ! Will you be writing the doc PR for this?

@zhichao-aws
Copy link
Member Author

Thanks, @zhichao-aws ! Will you be writing the doc PR for this?

Sure, I'll create a PR for this.

@hdhalter
Copy link
Contributor

HI @zhichao-aws - do you have a doc PR for this?

@zhichao-aws
Copy link
Member Author

HI @zhichao-aws - do you have a doc PR for this?

Will create one today

@zhichao-aws
Copy link
Member Author

PR created: #6725

@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. and removed 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. labels Mar 20, 2024
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete v2.13.0
Projects
None yet
2 participants