Variable drain timeouts when shutting down over HTTP shutdown. #4970
+751
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two new parameters to the shutdown API. The first is bufferReadTimeout which controls the amount of time to wait for the buffer to be empty. The second is bufferDrainTimeout which controls the overall wait time for the process worker threads to complete. To support Data Prepper durations in HTTP query parameters, I extracted the parsing logic for durations out of DataPrepperDurationDeserializer and into a new DataPrepperDurationParser class. Resolves opensearch-project#4966. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter and
oeyh
as code owners
Signed-off-by: David Venable <[email protected]>
graytaylor0
reviewed
Sep 22, 2024
|
|
||
| final Duration bufferReadTimeout = dataPrepperShutdownOptions.getBufferReadTimeout(); | ||
| if(bufferReadTimeout != null) { | ||
| forceStopReadingBuffersAt = shutdownRequestedAt.plus(bufferReadTimeout); |
There was a problem hiding this comment.
Does this only apply to the Kafka buffer? If this times out reading from in-memory buffer there is a chance of data loss right?
There was a problem hiding this comment.
This would apply to any buffer. But, it has to be provided in the /shutdown API request. So a user could force a faster shutdown even with the in-memory buffer using this.
dinujoh
reviewed
Sep 22, 2024
| bufferDrainTimeoutOverride : bufferDrainTimeout; | ||
| } | ||
|
|
||
| private Instant now() { |
There was a problem hiding this comment.
nit: This is returning the pipeline shutdown request time and not the current time ? We should consider renaming this.
dinujoh
approved these changes
Sep 22, 2024
graytaylor0
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two new parameters to the shutdown API. The first is bufferReadTimeout which controls the amount of time to wait for the buffer to be empty. The second is bufferDrainTimeout which controls the overall wait time for the process worker threads to complete.
To support Data Prepper durations in HTTP query parameters, I extracted the parsing logic for durations out of DataPrepperDurationDeserializer and into a new DataPrepperDurationParser class.
Issues Resolved
Resolves #4966.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.