Support BigDecimal data type in expressions #4930
Open
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kondaka <[email protected]>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
oeyh
reviewed
Sep 10, 2024
| @@ -12,6 +12,7 @@ | |||
| import javax.inject.Inject; | |||
| import javax.inject.Named; | |||
| import java.io.Serializable; | |||
| import java.math.BigDecimal; | |||
dlvenable
requested changes
Sep 10, 2024
| @@ -339,6 +340,7 @@ EXPONENTLETTER | |||
| ; | |||
|
|
|||
| INTEGER: 'integer'; | |||
| BIG_DECIMAL: 'big_decimal'; | |||
There was a problem hiding this comment.
Didn't we use the term decimal to be consistent with OpenSearch?
There was a problem hiding this comment.
@dlvenable I am not sure. We already use "big_decimanl" in https://github.com/opensearch-project/data-prepper/blob/main/data-prepper-api/src/main/java/org/opensearch/dataprepper/model/event/DataType.java. Should I change at both places?
Signed-off-by: Kondaka <[email protected]>
oeyh
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support BigDecimal data type in expressions
Issues Resolved
Resolves #4817
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.