Support start_time or range options for the first scan of scheduled s3 scan #4929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3 scan Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
4 tasks
san81
reviewed
Sep 10, 2024
| @@ -124,7 +125,7 @@ private List<PartitionIdentifier> listFilteredS3ObjectsForBucket(final List<Stri | |||
| .filter(keyTimestampPair -> !keyTimestampPair.left().endsWith("/")) | |||
| .filter(keyTimestampPair -> excludeKeyPaths.stream() | |||
| .noneMatch(excludeItem -> keyTimestampPair.left().endsWith(excludeItem))) | |||
| .filter(keyTimestampPair -> isKeyMatchedBetweenTimeRange(keyTimestampPair.right(), startDateTime, endDateTime)) | |||
| .filter(keyTimestampPair -> isKeyMatchedBetweenTimeRange(keyTimestampPair.right(), startDateTime, endDateTime, isFirstScan)) | |||
There was a problem hiding this comment.
Not sure if S3 scan api itself can take this filter? If yes, that should help filter out these records at the S3 end itself.
There was a problem hiding this comment.
Yeah would be nice to do this server side. ListObjectsV2 does not support it though (https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html)
san81
approved these changes
Sep 10, 2024
chenqi0805
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for start_time and range in scheduled s3 scan to filter on the first scan of the buckets based on the time. Previously scheduled scan would always process all objects on the first scan.
Tested with a pipeline to confirm that only objects within a given start_time and range are processed
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.