Work to reduce test time by reducing some repeated tests, using Awaitility, and reducing delays #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility, and reducing some wait times. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed and
oeyh
as code owners
4 tasks
Signed-off-by: David Venable <[email protected]>
graytaylor0
approved these changes
Jul 13, 2023
| @@ -137,7 +137,7 @@ private AggregateProcessor createObjectUnderTest() { | |||
| return new AggregateProcessor(aggregateProcessorConfig, pluginMetrics, pluginFactory, expressionEvaluator); | |||
| } | |||
|
|
|||
| @RepeatedTest(value = 10) | |||
| @RepeatedTest(value = 2) | |||
There was a problem hiding this comment.
I don't see an issue with just removing the @RepeatedTest annotation all together from these tests
asifsmohammed
approved these changes
Jul 21, 2023
I viewed the JUnit reports for these tests. That is also how I found some of the longer running tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes some attempts to improve our test times.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.