Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Accelerate Table Flyout not working(Flint Datasource) -expecting dataSourceType #348

Open
TackAdam opened this issue Jul 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@TackAdam
Copy link
Contributor

What is the bug?
For Flint datasources. the "Accelerate Table" flyout button opens a blank page due to dataSourceType being undefined.
This is introduced by opensearch-project/dashboards-observability@19d68b2
And is shown here https://github.com/opensearch-project/dashboards-observability/blob/b328720c11811d45da9d0594c5c28a18dd8fa2d0/public/components/datasources/components/manage/accelerations/create_accelerations_flyout/selectors/index_type_selector.tsx#L27

How can one reproduce the bug?

  1. Go to queryWorkBench and switch to a Flint data source.
  2. Click on Accelerate Table
  3. The flyout will be blank.
Screenshot 2024-07-11 at 2 54 14 PM Screenshot 2024-07-11 at 2 56 05 PM Screenshot 2024-07-11 at 2 53 58 PM

What is the expected behavior?
Using a commit prior to this for dashboards-observability such as
opensearch-project/dashboards-observability@e5af7eb works as intended

Screen.Recording.2024-07-11.at.2.32.59.PM.mov

What is your host/environment?

  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Plugins

Do you have any additional context?
queryWorkBench does not pass a dataSourceType and the undefined behavior will cause the flyout to fail.

@TackAdam TackAdam added bug Something isn't working untriaged labels Jul 11, 2024
@dblock dblock removed the untriaged label Jul 29, 2024
@dblock
Copy link
Member

dblock commented Jul 29, 2024

[Catch All Triage - 1, 2, 3, 4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants