Set up redux infrastructure #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
reviewed
Sep 21, 2023
owaiskazi19
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Looks good on my end but I'll wait for @jackiehanyang review before merging it.
|
LGTM! |
jackiehanyang
approved these changes
Sep 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit c73ffb0)
ohltyler
added a commit
that referenced
this pull request
Sep 21, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit c73ffb0) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets up the initial redux infrastructure for maintaining frontend state. We choose to use redux / react-redux / redux-toolkit libraries since it is the consistent way that core OSD + other plugins use, and is the standard across modern react applications. It also doesn't add any dependencies since we consume them from core OSD.
configureStorecreateSliceProviderso React components have access to the storeWorkflowBuilderpageTested with some basic functionalities, including adding some dummy components, and validating if there are changes. These are using the
componentsandisDirtyvars within theworkspacestate.screen-capture.16.webm
Issues Resolved
Makes progress on #8 & #10
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.