Added unit tests for WorkflowDetail component #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saimedhi <[email protected]>
saimedhi
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz,
jackiehanyang and
minalsha
as code owners
ohltyler
reviewed
Aug 29, 2024
Comment on lines
+47
to
+48
| expect(baseElement.tagName).toBe('BODY'); | ||
| expect(container.tagName).toBe('DIV'); |
There was a problem hiding this comment.
This isn't a useful thing to test. We should test that certain wording exists, or other descriptors of components that we would be expecting when this renders. I would recommend looking at the AD OSD plugin unit tests for more examples. You can also refer to the testing-library documentation for more info and examples.
At a high-level, we use jest as the test framework, and @testing-library/react as a helper library for rendering and pulling out UI elements. A basic flow for testing UI components/pages is:
- Render the component using
render()(optionally with different props for different states) - Run
testing-libraryqueries (linked above) against that returned component to ensure certain elements exist etc. - Assert that those queries return what is expected using
jest, such asexpect()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added unit tests for WorkflowDetail component
Issues Resolved
Related to #95
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.