Add quick-create fields in the create flow and form pre-population #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
added
backport 2.x
rapid
workflow details
new workflow
workflow editor
Roadmap:Ease of Use
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
Signed-off-by: Tyler Ohlsen <[email protected]>
joshpalis
approved these changes
Aug 23, 2024
dbwiddis
approved these changes
Aug 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 8f276e3)
ohltyler
added a commit
that referenced
this pull request
Aug 26, 2024
) (#310) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 8f276e3) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of the usability improvements. Specifically, this PR adds several standard quick-config fields to common use cases that users can optionally populate, before entering the advanced editor view. When populated, the values are then propagated into the workflow config in various places. Details below.
Implementation details:
QuickConfigureFieldstype containing a set of optional fieldsQuickConfigureInputscomponent, that dynamically renders form fields based on the use case. For example, a custom/blank use case, vs. a semantic search use case, vs other advanced / hybrid search / neural sparse search / future use cases, will have different inputs exposed. Current implementation shows the same fields available to semantic/multimodal/hybrid; this will expand in the futureQuickConfigureModalcomponent. ExposesQuickConfigureFieldsif applicable, and maintains any/all of those field values. When actually executing the creation, those field values are injected into the workflow configs to auto-populate different parts of the form. SeeinjectQuickConfigureFieldsand its child fns for details. The main idea, is each use case, we can maintain different logic for how some quick-create fields gets added into the initial workflow config when finally creating it and sending user to the detailed edit view.Demo video, showing the list of optional inputs in the modal. When filled out, you can see the values show up in different places in the form, such as 1/ the ML processor ingest processor config's model, input map, and output map, 2/ the knn index mappings, and 3/ the query on the search flow.
screen-capture.3.webm
Issues Resolved
Makes progress on #23
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.