Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve input constraints; general usability improvements #294

Merged
merged 6 commits into from
Aug 16, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Aug 16, 2024

Description

This PR covers a bunch of general usability improvements:

  • refactors the delete workflow modal into the workflow list module
  • updates the delete workflow modal by adding deprovisioning as an option (and setting it as the default) when deleting workflows from the list page
  • adds a 'failed to find workflow' dedicated page due to invalid id in url, for example
  • adds more loading state and visibility when deleting
  • adds input limits - max 1000 documents, max 100 chars for string, max 10000 chars for json string
  • adds regexp matching and character limit handling when defining workflow name from the new workflows page
  • adds getCharacterLimitedString() util fn to dynamically truncate strings if beyond the specified limit and adds an ellipses. Audited the entire plugin to ensure the workflow name, for example, is displayed properly, if the name is very long.
  • adds xss checks by sanitizing all scenarios when parsing url params
  • adds loading state to importing
  • makes JSON editor full-width

Demo video, showing the updated delete modal, invalid url page, and some general input handling checks.

screen-capture.26.webm

Issues Resolved

Makes progress on #23
Makes progress on #295

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler merged commit af7516f into opensearch-project:main Aug 16, 2024
6 checks passed
@ohltyler ohltyler deleted the usability-3 branch August 16, 2024 22:36
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 16, 2024
ohltyler added a commit that referenced this pull request Aug 16, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit af7516f)

Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants