Support optional params for all processors; onboard text_chunking processor #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
…plate conversion logic to single fn Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang and
minalsha
as code owners
9 tasks
dbwiddis
approved these changes
Aug 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
…cessor (#265) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit e2d22c3)
ohltyler
added a commit
that referenced
this pull request
Aug 6, 2024
…cessor (#265) (#266) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit e2d22c3) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables a pre-configured set of optional parameters for each processor type, all under an
Advanced settingsaccordion. It also adds the text chunking processor as an available option for ingest.More details:
optionalFieldsfield for each processor configTextChunkingProcessorInputsdue to its complexity; we display a different set of optional fields based on the selected text chunking algorithm. Also adds special logic inconfig_to_template_utilsto only add any configured optional fields relevant to the currently selected algorithm.booleanandnumberfields as optional config field typescamelCaseToTitleString()helper fn and removes thelabelfield in the config to help minimize what we persist on-cluster. We can now just generate the field title based on its ID.Demo video (existing processors with optional fields):
screen-capture.19.webm
Demo video (new text chunking ingest processor):
screen-capture.20.webm
Issues Resolved
Makes progress on #23
Makes progress on #219
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.