Side Nav Redesign #263
Merged
Side Nav Redesign #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saimedhi <[email protected]>
saimedhi
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz,
jackiehanyang and
minalsha
as code owners
b10ccf87-958a-4894-9f10-f505a4969701.webm |
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
Signed-off-by: saimedhi <[email protected]>
|
@SuZhou-Joe, Could you please review this PR? This PR only includes the new side nav changes. I will raise followup PR for header redesign.
|
|
LGTM UX-wise! Thank you! |
ohltyler
approved these changes
Aug 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
* Side Nav Redesign Signed-off-by: saimedhi <[email protected]> * Side Nav Redesign Signed-off-by: saimedhi <[email protected]> --------- Signed-off-by: saimedhi <[email protected]> Signed-off-by: Sai Medhini Reddy Maryada <[email protected]> (cherry picked from commit f0552d7)
saimedhi
added a commit
that referenced
this pull request
Aug 15, 2024
* Side Nav Redesign Signed-off-by: saimedhi <[email protected]> * Side Nav Redesign Signed-off-by: saimedhi <[email protected]> --------- Signed-off-by: saimedhi <[email protected]> Signed-off-by: Sai Medhini Reddy Maryada <[email protected]> (cherry picked from commit f0552d7) Co-authored-by: Sai Medhini Reddy Maryada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Recording with MDS feature merged - latest
screen-capture.6.webm
Issues Resolved
Related Issue: opensearch-project/OpenSearch-Dashboards#7029
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.