Use smaller and compressed varients of buttons and form components #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
AMoo-Miki
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz,
jackiehanyang and
minalsha
as code owners
ohltyler
reviewed
Aug 2, 2024
There was a problem hiding this comment.
Thanks @AMoo-Miki! Just one small syntax comment.
Btw, is there any standardized guidelines for this listed somewhere I can reference for the future?
| @@ -85,7 +85,7 @@ export function ModelField(props: ModelFieldProps) { | |||
| <Field name={props.fieldPath}> | |||
| {({ field, form }: FieldProps) => { | |||
| return ( | |||
| <EuiFormRow | |||
| <EuiompressedFormRow | |||
There was a problem hiding this comment.
Missing C. Same on lines 99 / 138
Viraj owns it. Can't tag him here somehow. |
Signed-off-by: Miki <[email protected]>
ohltyler
approved these changes
Aug 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
) Signed-off-by: Miki <[email protected]> (cherry picked from commit 9f9f74e)
ohltyler
pushed a commit
that referenced
this pull request
Aug 2, 2024
) (#259) Signed-off-by: Miki <[email protected]> (cherry picked from commit 9f9f74e) Co-authored-by: Miki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace instances of
EuiButtonthat don't have an explicit sizing attribute toEuiSmallButton*.Replace instances of
Eui<form elements>that don't have density attributes toEuiCompressed<form elements>.Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.