Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint script, workflow, and pre-commit hook #25

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Sep 5, 2023

Description

Follow-up to #3

  • adds a linting workflow to run lint on all src files on PR and push
  • adds precommit npm package and configuration to automatically run the linter on every commit

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler ohltyler merged commit e9a3116 into opensearch-project:main Sep 7, 2023
4 checks passed
@ohltyler ohltyler deleted the add-linting branch September 7, 2023 20:08
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit e9a3116)
ohltyler added a commit that referenced this pull request Sep 7, 2023
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit e9a3116)

Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants