Remove unnecessary js-yaml package
#240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Tyler Ohlsen <[email protected]>
|
test failure is unrelated, I've checked on much older branches, all fail the same when using the latest branch of OSD. Started failing on #231 . Will ignore for this PR. Still investigating |
dbwiddis
approved these changes
Jul 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 23179d6)
ohltyler
added a commit
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 23179d6) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Core OSD already has the
js-yamldependency managed. We remove the duplicate pulled into this plugin which can lead to build issues due to version mismatches. Confirmed everything works and the js-yaml uses in this codebase resolve correctly.Issues Resolved
N/A
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.