Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed draft_release_notes workflow and Renamed plugin #238

Merged

Conversation

saimedhi
Copy link
Collaborator

Description

fixed draft_release_notes workflow and Renamed plugin in package.json , opensearch_dashboards.json

Issues Resolved

Related to opensearch-project/opensearch-build#4851

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler
Copy link
Member

Seems the plugin rename is already covered in #234, can you update to only be in one or the other to prevent conflicts once one merges first?

@saimedhi
Copy link
Collaborator Author

Seems the plugin rename is already covered in #234, can you update to only be in one or the other to prevent conflicts once one merges first?

I changed in 2.x before and now in main.

Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah got it, since they are not overlapping. LGTM!

@ohltyler ohltyler merged commit 83e6b5e into opensearch-project:main Aug 2, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants