Complete advanced output transform (ingest) #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
…working Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
dbwiddis
approved these changes
Jul 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 2fcb819)
ohltyler
added a commit
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 2fcb819) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the advanced output transform flow on the ingest side. Specifically:
OutputTransformModaland the logic for fetching the input and generating the output. The notable difference is on fetching the input - for transforming the output, we run the simulate ingest pipeline API up to and including the currently-configured processor, but also removing any currently-configured output transforms. That way, we get a consistent and expected input to the output transform every time. It's also possible we refactor both of these modals into a single generic one - since the UI is not finalized, we wait to handle thatutilsto reuse in the input / output transform modalsMLProcessorInputs- moves the modal buttons underPreviewbuttons in-line with the formEuiCodeEditorto easily handle overflow/scrolling, as this data may be very long and complex (e.g., 1000-dimension embeddings)Demo video, showing the refactored form components, transform modals, a working output transform modal, and finally, ingest:
screen-capture.11.webm
Issues Resolved
Makes progress on #23
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.