-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump version to 2.17 #234
bump version to 2.17 #234
Conversation
Signed-off-by: saimedhi <[email protected]>
Why do we need to do version bump manually? Once onboarded to release framework, it should do the job on it's own to bump the versions. |
For autosync onboarding, I am using 2.x branch. From my understanding, initially version should be correct when onboarding to autosync (here 2.17) and for later releases it will automatically get bumped. Let me know if that is not the case. cc: @joshpalis |
@saimedhi lets wait for a second approval before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the changes.
Build is failing
|
Fixed in #240. Interestingly this wasn't failing before; I checked when there was any js-yaml dependency changes and there hasn't been anything changed recently. Either way, we can remove and consume from core OSD. |
@saimedhi can you update this to resolve the conflicts? |
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
@saimedhi are we ok to merge, or is there some issues with this version update in 2.x branch with 2.16 release still ongoing? |
From my understanding, current development is happening for 2.17. So, version should be 2.17 right? And also we did not add 2.x in build repo manifest. So ,may not produce any issue. |
Sounds good! I will merge. |
Description
Issues Resolved
closes #233
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.