Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to 2.17 #234

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

saimedhi
Copy link
Collaborator

Description

  • Bump version to 2.17.0.0
  • Renamed plugin in package.json , opensearch_dashboards.json

Issues Resolved

closes #233

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi <[email protected]>
@owaiskazi19
Copy link
Member

Why do we need to do version bump manually? Once onboarded to release framework, it should do the job on it's own to bump the versions.

@saimedhi
Copy link
Collaborator Author

Why do we need to do version bump manually? Once onboarded to release framework, it should do the job on it's own to bump the versions.

For autosync onboarding, I am using 2.x branch. From my understanding, initially version should be correct when onboarding to autosync (here 2.17) and for later releases it will automatically get bumped.

Let me know if that is not the case.

cc: @joshpalis

@joshpalis
Copy link
Member

@saimedhi lets wait for a second approval before merging

Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes.

@owaiskazi19
Copy link
Member

Build is failing

 [4/4] Building fresh packages...

ERROR [single_version_dependencies] Multiple version ranges for the same dependency
      were found declared across different package.json files. Please consolidate
error Command failed with exit code 1.
      those to match across all package.json files. Different versions for the
      same dependency is not supported.

      If you have questions about this please reach out to the operations team.

      The conflicting dependencies are:

        js-yaml
          ^3.14.0 => opensearch-dashboards, @osd/apm-config-loader, @osd/config, @osd/optimizer
          ^4.1.0 => dashboards-flow-framework
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@ohltyler
Copy link
Member

Build is failing

 [4/4] Building fresh packages...

ERROR [single_version_dependencies] Multiple version ranges for the same dependency
      were found declared across different package.json files. Please consolidate
error Command failed with exit code 1.
      those to match across all package.json files. Different versions for the
      same dependency is not supported.

      If you have questions about this please reach out to the operations team.

      The conflicting dependencies are:

        js-yaml
          ^3.14.0 => opensearch-dashboards, @osd/apm-config-loader, @osd/config, @osd/optimizer
          ^4.1.0 => dashboards-flow-framework
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Fixed in #240. Interestingly this wasn't failing before; I checked when there was any js-yaml dependency changes and there hasn't been anything changed recently. Either way, we can remove and consume from core OSD.

@ohltyler
Copy link
Member

ohltyler commented Aug 2, 2024

@saimedhi can you update this to resolve the conflicts?

Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
@saimedhi saimedhi requested a review from minalsha as a code owner August 2, 2024 21:18
@ohltyler
Copy link
Member

ohltyler commented Aug 2, 2024

@saimedhi are we ok to merge, or is there some issues with this version update in 2.x branch with 2.16 release still ongoing?

@saimedhi
Copy link
Collaborator Author

saimedhi commented Aug 2, 2024

is there some issues with this version update in 2.x branch with 2.16 release still ongoing?

From my understanding, current development is happening for 2.17. So, version should be 2.17 right? And also we did not add 2.x in build repo manifest. So ,may not produce any issue.

@ohltyler
Copy link
Member

ohltyler commented Aug 2, 2024

Sounds good! I will merge.

@ohltyler ohltyler merged commit 8eb1d87 into opensearch-project:2.x Aug 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants