-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guardrails to doc and query JSON inputs #231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
July 23, 2024 00:19
Signed-off-by: Tyler Ohlsen <[email protected]>
Seems some issue in core OSD causing the test failure. My older version of OSD is working. It is just a single test case:
|
and same issue on #232 to confirm it's unrelated. |
joshpalis
approved these changes
Jul 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 1b8486e)
ohltyler
added a commit
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 1b8486e) Co-authored-by: Tyler Ohlsen <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Naturally, the JSON schema of both the sample documents and the query have downstream impact on the ingest and search pipelines, respectively. To help prevent accidental changes, and to make the user make a more explicit choice when editing such fields, this moves those inputs into modals. Users have a readonly view of the values, but must click on an explicit 'Edit' to change the values.
More specifics:
SourceData
(ingest) andConfigureSearchRequest
(search) components, and moves the form configuration inside such modals. Readonly codeblocks are added to the base form page for users to see the current valuesFormik
form on the UImatch_all
queryIConfigField
interface as these have moved within the components themselves and are no longer persisted inui_metadata
.Demo video, showing the readonly views, and the flows for editing the doc and query fields (button texts and modal titles subject to change)
screen-capture.10.webm
Issues Resolved
Makes progress on #23
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.