Add error field to workflow; propagate all runtime errors in tools tab #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
joshpalis
approved these changes
Jul 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
#210) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 9f7e6eb)
ohltyler
added a commit
that referenced
this pull request
Jul 11, 2024
#210) (#211) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 9f7e6eb) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates some of the error handling and finishes the
Errorstab in theToolscomponent.Toolswill automatically switch to theErrorstab if any of the following occur:errorfield within the workflow state will be populated if some intermediate step may have failed (e.g., index already exists when provisioning, error creating ingest pipeline, etc.)To handle the last case, we need to persist the error found in redux store, similar to the workflow state. This PR adds the optional
errorto theWorkflowinterface and persists it when it is found in API responses on server-side (both the get workflow path, and the search workflow path that could be multiple workflows)Other minor changes:
Demo video shows an example of 2 different types of failures:
1/ error when running ingest due to the document being in an invalid format when passed to the LLM via the ML inference processor
2/ error when provisioning a workflow since the index name is already created
In both cases, the
Toolstab automatically redirects to theErrorstab and displays the relevant message. Final formatting of the error message is TBD as there is no UX for that.screen-capture.2.webm
Issues Resolved
Makes progress on #23
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.