Simplify ui_metadata; various cleanup and refactoring
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Tyler Ohlsen <[email protected]>
joshpalis
approved these changes
Jul 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit ad03380)
ohltyler
added a commit
that referenced
this pull request
Jul 9, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit ad03380) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a lot of cleanup on various parts of the codebase:
ui_metadatato not persist low-level form details, and instead generate them when rendering the component (e.g.,helpText/helpLink). The goal is to minimize what we need to persist inui_metadataas this is what is indexed on the cluster. More will be removed once the configuration around ML inference processors is finalized (UX is still TBD on this part). To do this, we remove these fields from theconfigs/, and inject them directly into the individual components.prototype/, as this is out of scope and is no longer useful, 3/data_extractor_utilswhich was used for parsing out ReactFlow configurations that is no longer used, 4/ the pre-configured ReactFlow components undernew_workflow/utils, since we currently are not using them. The current scope is just around the form, and generating the ReactFlow components based on such form. And 5/ the legacySelectFieldand its various interfaces.ModelFieldto be scoped to just selecting deployed models, and removing all provisioning & pretrained model logic.tools/into standaloneQuery/Ingest/ErrorsmodulesConfirmed existing form logic, validation, testing, and general workflow editing and creation still works as expected. Also confirmed the underlying template does not persist the unnecessary fields anymore.
Issues Resolved
Makes progress on #23, #66
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.