Integrate query into form (not persisted in config) #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
| processorsSchemaObj[processorConfig.id] = yup.object(processorSchemaObj); | ||
| }); | ||
|
|
||
| return yup.object(processorsSchemaObj); |
There was a problem hiding this comment.
I could be wrong as I'm not very familiar with the Yup library, had to look up the Yup library documentation about yup.object to understand what we're trying to do here - define the schema. I see there's another method - yup.object().shape, that defines the structure and validation rules for an object. Should we change to use yup.object().shape here as yup.object() just defines the structure without any constraints?
There was a problem hiding this comment.
The parameters passed in object are where the constraints are set - see documentation. Passing verbosely with shape achieves the same thing, but prefer the short-form to keep it simpler.
jackiehanyang
approved these changes
Jun 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 8afac97)
ohltyler
added a commit
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 8afac97) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to the way we persist the ingest documents, we persist the query in the same form. This means:
1/ integrating with the overall form for schema/validation and temporary persistence
2/ not integrating with the underlying, persisted, indexed, config.
More details:
ResizableWorkspacelike the ingest docsConfigureSearchRequestto be similar to the ingest docs form, utilizing theJsonFieldcomponent (which handles the auto-formatting as well)validateAndRunQuery()to ensure there is a valid, non-empty query, when attempting to click 'Run query' buttonDemo video showing validation, auto-formatting, persistence across page navigation, and finally the query execution:
screen-capture.39.webm
Issues Resolved
Makes progress on #23
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.