Update create workflow, update workflow, and form validation logic #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
…om use case page Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
ohltyler
added
rapid
new workflow
workflow editor
backport 2.x
and removed
backport 2.x
labels
joshpalis
approved these changes
Jun 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 691c3b8)
ohltyler
added a commit
that referenced
this pull request
Jun 5, 2024
) (#165) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 691c3b8) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates and refactors a variety of functionality related to form validation and workflow updates, to match with the updated UX. Specifically:
NewWorkflowto read asCreate, and update the functionality to actually create a preset workflow and load the editor page with the newly-created workflow automatically with the created IDnew/temporary/cached workflow, and all related code, frontend state, and redux store logic for it. Now, the editor page can only be loaded using a created workflow in the backend with a persisted IDWorkflowInputsto match the UX. There will now be no explicitcreatebuttons, and will only beIngest/Searchbuttons to execute ingest and search. Internal updates to the workflow and fine-grained provisioning will happen behind the scenesWorkflowInputsdirectly. This will slowly change over time as (potentially) auto-update and more of the internal update and execution logic has been implemented.WorkflowInputscomponent. This will be used when performing the actual ingest execution.Demo video, showing auto-creation, and new buttons on
WorkflowInputscomponent:screen-capture.35.webm
Issues Resolved
Makes progress on #23
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.