Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Tools collapsible panel #162

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

ohltyler
Copy link
Member

Description

Per the latest UX mockups, this PR adds a 'Tools' component. It is resizable and collapsible similar to the workflow inputs component. The purpose of this component is for viewing results of ingestion, results of search, any errors, and the list of created resources from this particular workflow. Demo video below. Most tabs are placeholders for now; future work will refactor some of the existing Ingestor and QueryExecutor components to live under the Run ingestion and Run queries tabs, respectively.

More details:

  • refactors the base components in ResizableWorkspace to have a new ResizableContainer containing the drag-and-drop workspace, and the new Tools component
  • creation of a new Tools component with multiple tabs
  • minor styling changes to support the refactoring
  • minor removal of some unused code in ResizableWorkspace
  • minor removal of some unused code in Workspace
  • refactoring all components under resources/ to live as a sub-directory within the base tools directory

Demo video:

demo.webm

Issues Resolved

Makes progress on #23

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler merged commit 8a965a3 into opensearch-project:main May 30, 2024
11 checks passed
@ohltyler ohltyler deleted the tools-panel branch May 30, 2024 17:32
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 30, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 8a965a3)
ohltyler added a commit that referenced this pull request May 30, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 8a965a3)

Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants