Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete conversions between config <-> form <-> template #156

Merged
merged 3 commits into from
May 16, 2024
Merged

Complete conversions between config <-> form <-> template #156

merged 3 commits into from
May 16, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented May 16, 2024 •
edited
Loading

Description

This PR completes the initial refactoring to support basic conversions of the config data to finally produce an end-to-end functional workflow. Specifically:

  • implements logic to convert form values -> UI config by injecting the values
  • implements logic to convert UI config -> final workflow template
  • updates few existing interfaces to include sufficient information to create the workflow template. For example, the type of model (text embedding vs. sparse encoder vs. other) influences the template construction
  • removes legacy logic for template conversion. The rest of what can/will be removed is tracked in Remove legacy ReactFlow workspace-related code #155

Demo video showing workflow creation working and form data persisted and auto-populated after creation (may ignore some of the form state such as auto-changing to existing model, etc. this will be updated over time). From dev tools, confirmed provisioning and resources work as expected for the following use cases:

  • semantic search w/ existing model
  • semantic search w/ new, pretrained model
screen-capture.33.webm

Issues Resolved

Makes progress on #23

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler merged commit 0d73288 into opensearch-project:main May 16, 2024
11 checks passed
@ohltyler ohltyler deleted the template-conversion branch May 16, 2024 18:26
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 16, 2024
@ohltyler @github-actions
Complete conversions between config <-> form <-> template (#156)
5b6b2c3 
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 0d73288)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 16, 2024
Merged
ohltyler added a commit that referenced this pull request May 16, 2024
@opensearch-trigger-bot @ohltyler
Complete conversions between config <-> form <-> template (#156) (#157)
8ab27a5 
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 0d73288)

Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpalis joshpalis joshpalis approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

Assignees
No one assigned
Labels
backport 2.x rapid refactor Refactoring / renaming workflow editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohltyler @joshpalis