Add new workflow config interfaces #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
added
backport 2.x
rapid
refactor
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
ohltyler
changed the title
dbwiddis
approved these changes
May 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 13, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 4a0ade3)
ohltyler
added a commit
that referenced
this pull request
May 13, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 4a0ade3) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds several base interfaces used in the new form/configuration component on the workflow editor page. These are kept generic for now until more details of the form inputs are finalized from UX. The base
WorkflowConfigwill live under the newconfigfield added in theui_metadatainterface. The main idea is this baseconfigwill capture all of the input in the form, and will be used for generating the 1/ form values, 2/yupvalidation schema, and 3/ the ReactFlow workspace's nodes/edges. The initial conversion fns have been added and stubbed.Additionally, the form & schema values in
ResizableWorkspace(formValues,formSchema) have changed from the workspace-flow-based form/schema, to the new interfaces, since these will be the source of truth, instead of the workspace nodes/edges being the source of truth. For now, we will leave those interfaces as they may prove useful later on, such as when full drag-and-drop functionality is supported.This PR also removes the default workspace flow values (the sets of nodes/edges) for the various use cases; now we will only care about providing default values under
config, since these will determine the final workspace flow. Defaults/presets are stubbed and left empty for now.Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.