Initial refactoring of workflow editor page #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Tyler Ohlsen <[email protected]>
minalsha
approved these changes
May 10, 2024
joshpalis
approved these changes
May 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 10, 2024
* Refactor resizableworkspace; add workflowinputs component Signed-off-by: Tyler Ohlsen <[email protected]> * Add stub components for the basic ingest and search configs Signed-off-by: Tyler Ohlsen <[email protected]> * More cleanup Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit c74260f)
ohltyler
added a commit
that referenced
this pull request
May 10, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit c74260f) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There has been recent changes to the proposed UX. The previous proposal was filling out inputs individually within a selected ReactFlow component. The new proposal is a more guided/structured way of filling out inputs. Now, it is form based via a single, stepped form with all of the required inputs end-to-end in one view. As users fill it out, the workspace components automatically populate based on the inputs. The workspace itself remains readonly. And for further testing, there will be a new tools view for executing ingest and search, all within the single page (no tabs / other dedicated views).
This PR handles the initial refactoring and setup of the stubbed form input components to be implemented incrementally. More specifically:
WorkflowInputscomponent & several child components for breaking up the required inputs for both ingest and search flows. The child components are stubbed for now.ResizableWorkspaceto include the newWorkflowInputscomponent and removes theComponentInputscomponent previously used for dynamically showing the form for an individual component in the dnd workspaceWorkflowInputsand a laterToolscomponentDemo video below shows the new
WorkflowInputscomponent and it's stepped flow. All form inputs are stubbed for now.screen-capture.30.webm
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.