Refactor component types and component inheritance #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
commented
Mar 12, 2024
| @@ -6,7 +6,8 @@ | |||
| "ui": true, | |||
| "requiredBundles": [], | |||
| "requiredPlugins": [ | |||
| "navigation" | |||
| "navigation", | |||
| "opensearchDashboardsUtils" | |||
There was a problem hiding this comment.
needed for createGetterSetter() used in services.ts. Was recently removed from requiredBundles due to it causing build errors, but without it it causes runtime errors. Correct pattern is to include this in requiredPlugins.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 19.30% 25.42% +6.12%
==========================================
Files 50 53 +3
Lines 746 763 +17
Branches 71 73 +2
==========================================
+ Hits 144 194 +50
+ Misses 595 562 -33
Partials 7 7 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
Mar 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 616b1cb)
ohltyler
added a commit
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 616b1cb) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors, renames, and improves upon the UI component class hierarchy used in the drag-and-drop workspace:
Demo video with hardcoded workflow state:
screen-capture.16.webm
Issues Resolved
Makes progress on #73
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.