Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy ReactFlow workspace-related code #155

Closed
ohltyler opened this issue May 16, 2024 · 2 comments
Closed

Remove legacy ReactFlow workspace-related code #155

ohltyler opened this issue May 16, 2024 · 2 comments
Labels
refactor Refactoring / renaming

Comments

@ohltyler
Copy link
Member

Recent UX changes changed the paradigm of persisting form data within a ReactFlow workspace -> persisting within a form component. As a consequence, there is a lot of legacy code that can be removed once the base refactoring of existing functionality is complete. This includes:

  • refactoring the component_types/ classes to be simplified and not contain form data. Many may be removed as well
  • constants related to component_types no longer in use
  • the entire component_details component once relevant code has been refactored elsewhere
  • utility / conversion fns to convert between form <-> component data <-> workflow template no longer in use
@dblock
Copy link
Member

dblock commented Jun 24, 2024

Catch All Triage - 1 2 3 4 5 6

@dblock dblock removed the untriaged label Jun 24, 2024
@ohltyler
Copy link
Member Author

Been completed via several PRs over time. Resolving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring / renaming
Projects
None yet
Development

No branches or pull requests

2 participants