Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable linting and codecov mechanisms #109

Open
Tracked by #245
ohltyler opened this issue Mar 6, 2024 · 2 comments
Open
Tracked by #245

Re-enable linting and codecov mechanisms #109

ohltyler opened this issue Mar 6, 2024 · 2 comments

Comments

@ohltyler
Copy link
Member

ohltyler commented Mar 6, 2024

#108 disabled the lint workflow to have ongoing development still have fully passing PRs and tracking main/2.x branches. Before this is released and before the plugin becomes more stable, this should be re-enabled to enforce lint checking on PRs and merges to main/2.x.

UPDATE: the PR was closed as this was disabled from github itself. details in referenced PR. This can be re-enabled the same way, at which time we can close this issue.

Additional linting mechanisms to re-enable:

  1. pre-commit configuration:
    In package.json, add:
  "pre-commit": [
    "lint:es:precommit"
  ],
  1. pre-commit dependency:
    add this in devDependencies:
  "devDependencies": {
    "pre-commit": "^1.2.2"
  },
  1. pre-commit script
    add this script under scripts in package.json:
    "lint:es:precommit": "yarn lint:es common/* public/* server/*",
  1. Re-enable pre-commit hooks in .git/hooks in the repository

  2. Re-enable codecov. Details of it being disabled in Parse and persist UI metadata on editor page #125

@ohltyler
Copy link
Member Author

ohltyler commented Mar 6, 2024

Setting 2.15 as a target goal to have this workflow re-enabled.

@ohltyler
Copy link
Member Author

ohltyler commented Apr 5, 2024

UPDATE: below details added in issue description


Additionally, pre-commit configuration should be added back, to enable linting on every commit by default. It was removed due to lint violations during rapid development and the fatigue of constantly adding --no-verify when committing:

In package.json, add:

  "pre-commit": [
    "lint:es:precommit"
  ],

add this in devDependencies:

  "devDependencies": {
    "pre-commit": "^1.2.2"
  },
```,

add this script:
"lint:es:precommit": "yarn lint:es common/* public/* server/*",

re-enable pre-commit hooks in `.git/hooks` in the repository

@ohltyler ohltyler changed the title Re-enable lint workflow Re-enable linting mechanisms Apr 5, 2024
@ohltyler ohltyler changed the title Re-enable linting mechanisms Re-enable linting and codecov mechanisms Apr 5, 2024
@ohltyler ohltyler added 2.17 and removed 2.15 labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants