Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] obfuscate ip addresses in alert error message #523

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b8e6e75 from #511.

* obfuscate ip addresses in alert error message

Signed-off-by: Surya Sashank Nistala <[email protected]>

* make ip obfuscation lower case

Signed-off-by: Surya Sashank Nistala <[email protected]>

* update test with lowercase ip obfuscation

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit b8e6e75)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #523 (62d1904) into 2.x (b88b51b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x     #523      +/-   ##
============================================
+ Coverage     73.56%   73.58%   +0.02%     
  Complexity      851      851              
============================================
  Files           130      130              
  Lines          5651     5656       +5     
  Branches        696      696              
============================================
+ Hits           4157     4162       +5     
  Misses         1187     1187              
  Partials        307      307              
Files Changed Coverage Δ
...g/opensearch/commons/alerting/alerts/AlertError.kt 44.44% <100.00%> (+12.62%) ⬆️

@engechas engechas merged commit b2a7ca6 into 2.x Apr 11, 2024
12 of 13 checks passed
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
opensearch-project#523)

* obfuscate ip addresses in alert error message



* make ip obfuscation lower case



* update test with lowercase ip obfuscation



---------


(cherry picked from commit b8e6e75)

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants